Skip to content

jankyborders: init #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2025
Merged

jankyborders: init #838

merged 1 commit into from
Sep 23, 2025

Conversation

Eveeifyeve
Copy link
Member

@Eveeifyeve Eveeifyeve commented Feb 7, 2025 •
edited
Loading

Adds the Jankyborders nix-darwin module.
Jankyborders is a popular ricing tool for styling borders on macOS.

Setup using jankyborders on nix-darwin:

image
Credit: @Lalit64 (dotfiles)

@Eveeifyeve
Copy link
Member Author

I will do testing in my configuration to make sure it works.

@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 4 times, most recently from 3ae65cb to 0b51343 Compare February 7, 2025 19:49
@Eveeifyeve
Copy link
Member Author

Eveeifyeve commented Feb 7, 2025 •
edited
Loading

bruh... RATE LIMITED by GitHub. Welp time to touch grass for an hour, XD.

@Eveeifyeve
Copy link
Member Author

Doesn't work as the colors go based of AARRGGBB is that even possible in stylix @danth?

@Lalit64
Copy link
Contributor

Lalit64 commented Feb 8, 2025 •
edited
Loading

@Eveeifyeve Oh my god, imagine people actually seeing your config .

Regarding the AARRGGBB, you should just be able to format the string no? I will take a look at the code in the evening and check it out.

@Eveeifyeve
Copy link
Member Author

@Eveeifyeve Oh my god, imagine people actually seeing your config.

Yeah I am trying to make a vertical bar on both with this styling this is based on my linux I am trying to rice my macOS so I can be one of the firsts to have 1. a clean config 2. have full ricing support for macOS and NixOS:
image

Regarding the AARRGGBB, you should just be able to format the string no? I will take a look at the code in the evening and check it out.

Well I had a look in the documentation idk if it's possible to use a base16 color? but to be honest idk, I would like to get this out so my borders look exactly like hyprlands.

@Eveeifyeve
Copy link
Member Author

Eveeifyeve commented Feb 8, 2025 •
edited
Loading

Then I want to do a pr for sketchybar but I don't know how I would support that as it contains a command not a config file to run it, I might have to make a pr in nix-darwin to add support for the way of doing it though nix instead of args to a cli command.

@Eveeifyeve
Copy link
Member Author

So yeah full setup is:

  • NixOS: Hyprland & Eww
  • macOS: JankyBorders, Sketchybar and aerospace

trueNAHO
trueNAHO reviewed Feb 8, 2025
View reviewed changes
danth
danth reviewed Feb 12, 2025
View reviewed changes
@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 2 times, most recently from f2a1c4e to c64d154 Compare February 17, 2025 04:18
@Eveeifyeve
Copy link
Member Author

CI is failing because I haven't rebased.

@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 2 times, most recently from 7d4c06e to 21a0266 Compare February 17, 2025 05:43
trueNAHO
trueNAHO requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR ready to merge?

@Eveeifyeve
Copy link
Member Author

Is this PR ready to merge?

Almost some issues that need to fixed and code needs to be refined.

@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 2 times, most recently from 4646ebd to 7d91feb Compare February 28, 2025 15:13
@trueNAHO
Copy link
Member

Is this PR ready to merge?

Almost some issues that need to fixed and code needs to be refined.

What is the status of this PR?

@Eveeifyeve
Copy link
Member Author

Eveeifyeve commented Feb 28, 2025 •
edited
Loading

Is this PR ready to merge?

Almost some issues that need to fixed and code needs to be refined.

What is the status of this PR?

Status of this pr is that the borders are not being produced at all, I've tested in my configuration and still doesn't work.

@danth danth added the kind: feature Feature request label Mar 11, 2025
@Eveeifyeve
Copy link
Member Author

Is this PR ready to merge?

Almost some issues that need to fixed and code needs to be refined.

What is the status of this PR?

Status of this pr is that the borders are not being produced at all, I've tested in my configuration and still doesn't work.

@Lalit64 perhaps do you know what is causing this?

@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 2 times, most recently from 2f4bbdb to bf91d8e Compare April 18, 2025 09:47
@Eveeifyeve
Copy link
Member Author

I managed to get it to work Pr is ready for review.

@Eveeifyeve
Copy link
Member Author

image

It not the brightest but you can debug it in launchctl

@trueNAHO trueNAHO added the backport: release-25.05 Changes to release-25.05 stable branch label Sep 8, 2025
@Eveeifyeve Eveeifyeve force-pushed the jankyborders/init branch 2 times, most recently from 7fd5d85 to 1c91337 Compare September 9, 2025 05:15
@Eveeifyeve Eveeifyeve requested a review from trueNAHO September 9, 2025 05:15
awwpotato
awwpotato previously requested changes Sep 9, 2025
View reviewed changes
@awwpotato
Copy link
Contributor

you need to run nix run .#all-maintainers

@Eveeifyeve

This comment was marked as resolved.

Sign in to view
@Eveeifyeve
Copy link
Member Author

you need to run nix run .#all-maintainers

Idk if this is normal cp: illegal option -- -?

I just needed to go into dev-shell.

@Eveeifyeve Eveeifyeve requested a review from Lalit64 September 12, 2025 08:16
@stylix-automation stylix-automation bot removed the status: merge conflict Merge conflict label Sep 15, 2025
trueNAHO
trueNAHO requested changes Sep 15, 2025
View reviewed changes
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for one minor thing.

@arieimer, feel free to test this PR and report whether it works.

trueNAHO
trueNAHO approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Eveeifyeve, could you test this PR one more time with the new minor changes made?

@Eveeifyeve
Copy link
Member Author

LGTM. @Eveeifyeve, could you test this PR one more time with the new minor changes made?

Yeah and I will merge all the commits into one commit

@Eveeifyeve
Copy link
Member Author

2910a7c is tested, I will be squashing the commits shortly.

@Eveeifyeve
jankyborders: init
27d829f 
jankborders: migrate to mkOpacityHexColor

jankyborders: convert to mkTarget

Update modules/jankyborders/darwin.nix

Co-authored-by: awwpotato <[email protected]>

Update modules/jankyborders/darwin.nix

Co-authored-by: NAHO <[email protected]>

jankyborders: format file

jankyborders: add missing lib argument
@Eveeifyeve
Copy link
Member Author

Ready and tested!

@trueNAHO trueNAHO enabled auto-merge (squash) September 23, 2025 07:17
@trueNAHO trueNAHO dismissed awwpotato’s stale review September 23, 2025 07:19

#838 (comment) has been resolved and the rest of the PR should be fine.

@trueNAHO trueNAHO disabled auto-merge September 23, 2025 07:20
@trueNAHO trueNAHO merged commit ef025b8 into nix-community:master Sep 23, 2025
9 of 10 checks passed
stylix-automation bot pushed a commit that referenced this pull request Sep 23, 2025
@Eveeifyeve @trueNAHO @github-actions
jankyborders: init (#838)
8518525 
Link: #838

Reviewed-by: awwpotato <[email protected]>
Reviewed-by: Lalit Yalamanchili <[email protected]>
Co-authored-by: NAHO <[email protected]>
Reviewed-by: NAHO <[email protected]>
(cherry picked from commit ef025b8)
@stylix-automation Stylix Automation
Copy link
Contributor

Successfully created backport PR for release-25.05:

@github-actions github-actions bot added the has: port to stable This has been backported to the latest stable branch label Sep 23, 2025
@stylix-automation stylix-automation bot mentioned this pull request Sep 23, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueNAHO trueNAHO trueNAHO approved these changes

@danth danth Awaiting requested review from danth

@awwpotato awwpotato Awaiting requested review from awwpotato

+1 more reviewer

@Lalit64 Lalit64 Lalit64 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport: release-25.05 Changes to release-25.05 stable branch has: port to stable This has been backported to the latest stable branch kind: feature Feature request topic: darwin nix-darwin target topic: documentation Documentation additions or improvements topic: droid Nix-on-Droid target topic: home-manager Home Manager target topic: modules /modules/ subsystem topic: nixos NixOS target topic: stylix /stylix/ subsystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Eveeifyeve @Lalit64 @trueNAHO @awwpotato @arieimer @danth