unbreak django.forms.util(s) import for django < 1.7 #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think is better to import django.forms.utils from django 1.7 included to avoid a deprecation warning as I do in #34. Sorry for the first breaks of django 1.6 … |
|
@bouttier fixed |
|
👍 |
|
Is this going to be released any time soon? |
|
@nkunihiko is your project still maintained ? |
|
Is this going to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.6 and before will not work with the new import naming, and full removal of old path was not removed until 1.9.
This conditionally imports the new name based on django version >= 1.9.
Tested locally in Django 1.6, and 1.7, and faked out the system by manually setting the version to 1.9