-
Couldn't load subscription status.
- Fork 91
feat: add support for Visual Studio 2026 #319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi team, This is my first PR here! I've tested the change successfully on the VS 2026 Insider Preview locally. I was unable to run the full test suite on Windows due to the known Thanks for adding the Windows label! I'm ready for the review process and for the CI/CD workflows to be approved and run. |
|
Follow-up: Just wanted to confirm that I was able to successfully run the full unit test suite (29 passed, 5 skipped) after some local environment setup. The code is stable and passes all existing tests. |
|
Can one or more tests be added to verify that this performs the expected actions? Also, |
|
Hi cclauss, thanks for the review! I've fixed the E501 line length issue in a new commit. Regarding testing: I've verified this change performs the expected actions by successfully generating and compiling the Breakpad project using the Ninja backend with VS 2026. The change also passes the existing unit test suite locally (29 passed, 5 skipped). Could you please approve the workflows so the CI can run the full test matrix? Thanks! |
|
Thanks for this work. I see you have a PR with same changes in node--gyp repo. I assume the idea is to land this one, close the other one, and then pull it in as a gyp-next update. Correct? |
|
Yes, that's correct |
|
OK, the changes seem reasonable. Simply enabling a new VS version. One thing that needs to be done after this lands in node-gyp is to add tests there for the new VS version, eg. |
|
Understood. Tests for VS 2026 in node-gyp will be added after the gyp-next update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
This pull request introduces initial support for the upcoming Visual Studio 2026 (internal version 18.0).
The key changes include:
SelectVisualStudioVersionand_DetectVisualStudioVersions. This allows GYP to correctly identify VS 2026 installations.VisualStudioVersiondefinition for '2026' in the_CreateVersionfunction.default_toolsettov145. This aligns with the toolset version observed in the Visual Studio 2026 Insider Preview builds, resolving potentialMSB8020errors for users on the latest previews.These changes enable developers using early versions of Visual Studio 2026 to generate and build projects with GYP seamlessly.