-
-
Notifications
You must be signed in to change notification settings - Fork 487
feat: add SharedArrayBuffer #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KevinEady
wants to merge
2
commits into
main
Choose a base branch
from
add-sharedarraybuffer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+327
−0
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| # ArrayBufferLike | ||
|
|
||
| Class `Napi::ArrayBufferLike` inherits from class [`Napi::Object`][]. | ||
|
|
||
| The `Napi::ArrayBufferLike` class is the base class for [`Napi::ArrayBuffer`][] | ||
| and [`Napi::SharedArrayBuffer`][]. It adds common array buffer capabilities to | ||
| both. It is an abstract-only base class. | ||
|
|
||
| ### ByteLength | ||
|
|
||
| ```cpp | ||
| size_t Napi::ArrayBufferLike::ByteLength() const; | ||
| ``` | ||
|
|
||
| Returns the length of the wrapped data, in bytes. | ||
|
|
||
| ### Data | ||
|
|
||
| ```cpp | ||
| void* Napi::ArrayBufferLike::Data() const; | ||
| ``` | ||
|
|
||
| Returns a pointer the wrapped data. | ||
|
|
||
| [`Napi::ArrayBuffer`]: ./array_buffer.md | ||
| [`Napi::Object`]: ./object.md | ||
| [`Napi::SharedArrayBuffer`]: ./shared_array_buffer.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # SharedArrayBuffer | ||
|
|
||
| Class `Napi::SharedArrayBuffer` inherits from class [`Napi::ArrayBufferLike`][]. | ||
|
|
||
| The `Napi::SharedArrayBuffer` class corresponds to the | ||
| [JavaScript `SharedArrayBuffer`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/SharedArrayBuffer) | ||
| class. | ||
|
|
||
| **NOTE**: The support for `Napi::SharedArrayBuffer` is only available when using | ||
| `NAPI_EXPERIMENTAL` and building against Node.js headers that support this | ||
| feature. | ||
|
|
||
| ## Methods | ||
|
|
||
| ### New | ||
|
|
||
| Allocates a new `Napi::SharedArrayBuffer` instance with a given length. | ||
|
|
||
| ```cpp | ||
| static Napi::SharedArrayBuffer Napi::SharedArrayBuffer::New(napi_env env, size_t byteLength); | ||
| ``` | ||
|
|
||
| - `[in] env`: The environment in which to create the `Napi::SharedArrayBuffer` | ||
| instance. | ||
| - `[in] byteLength`: The length to be allocated, in bytes. | ||
|
|
||
| Returns a new `Napi::SharedArrayBuffer` instance. | ||
|
|
||
| ### Constructor | ||
|
|
||
| Initializes an empty instance of the `Napi::SharedArrayBuffer` class. | ||
|
|
||
| ```cpp | ||
| Napi::SharedArrayBuffer::SharedArrayBuffer(); | ||
| ``` | ||
|
|
||
| ### Constructor | ||
|
|
||
| Initializes a wrapper instance of an existing `Napi::SharedArrayBuffer` object. | ||
|
|
||
| ```cpp | ||
| Napi::SharedArrayBuffer::SharedArrayBuffer(napi_env env, napi_value value); | ||
| ``` | ||
|
|
||
| - `[in] env`: The environment in which to create the `Napi::SharedArrayBuffer` | ||
| instance. | ||
| - `[in] value`: The `Napi::SharedArrayBuffer` reference to wrap. | ||
|
|
||
| [`Napi::ArrayBufferLike`]: ./array_buffer_like.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we use the name
XxxLikewhen it describes a shape of a protocol. For ArrayBuffer and SharedArrayBuffer, this is not the case. TheNapi::ArrayBufferandNapi::SharedArrayBufferdo not work with a JavaScript mocked ArrayBuffer-like objects.I think a better name can be
ArrayBufferBase. Or just duplicate these two methods as in JavaScript,ArrayBufferandSharedArrayBufferhave no common ancestry.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in f861d36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with the approach of: