Skip to content

Conversation

avivkeller
Copy link
Member

Follow-up #8057.

Now that we have a basic package, this PR modifies the rules to use @nodejs/doc-kit's functionality, ensuring that any changes their get reflected in the linter.

Why was this separate from #8057? I wanted a version (1.0.0) which is almost a drop-in replacement for the original linter, without relying on @nodejs/doc-kit, in case something broke.

@avivkeller avivkeller requested review from a team as code owners August 22, 2025 23:32
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Aug 26, 2025 9:12pm

Copy link

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 98.26087% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.06%. Comparing base (2dc1023) to head (7eb2bd9).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...emark-lint/src/rules/duplicate-stability-nodes.mjs 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8106      +/-   ##
==========================================
+ Coverage   75.88%   76.06%   +0.18%     
==========================================
  Files         112      114       +2     
  Lines        9433     9513      +80     
  Branches      303      313      +10     
==========================================
+ Hits         7158     7236      +78     
- Misses       2274     2275       +1     
- Partials        1        2       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avivkeller
Copy link
Member Author

@nodejs/web what other lint rules are needed?

I'm thinking:

  • Typed lists syntax
  • Stability node syntax
  • Alphabetical typed headings

What else?

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC, when we add new rules, in which repositories are they being applied? doc-kit? So it means Node's core API docs? Shouldn't then any PR to remark-lint actually require nodejs/collaborators as code owners?

@avivkeller
Copy link
Member Author

OOC, when we add new rules, in which repositories are they being applied? doc-kit? So it means Node's core API docs? Shouldn't then any PR to remark-lint actually require nodejs/collaborators as code owners?

My plan is for these to be applied to nodejs/node once the new tooling is adopted (but it is not dependent on, and could land beforehand).

The previous implementation did not have any CODEOWNERS, thus, this is the same, however, that can change

Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Aug 26, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 26, 2025
Copy link
Contributor

github-actions bot commented Aug 26, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 82 🟢 100 🟢 100 🟢 100 🔗
/en/about 🟢 99 🟢 97 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 97 🟢 93 🟢 100 🟠 89 🔗
/en/download 🟢 90 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants