-
Notifications
You must be signed in to change notification settings - Fork 33
Update lib_examples/base64_example #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think there should be 1613 file changes in this PR. Can you update the .gitignore?
Hi @critesjosh , |
Hi @critesjosh . The large number of file changes was due to auto-generated files in I've now done the following:
Please let me know if the file change count looks okay now. Thanks. |
Can you just update it to work with the latest version with minimal modifications to the existing code? I'd like to keep the example as simple as possible. |
Hello @critesjosh , I hope you’re well. I’ve made the requested updates and resolved the issues highlighted in your previous review. Thanks for your guidance. Could you please take another look at the pull request when you have a moment? Your feedback is greatly appreciated. Thank you very much for your time! Best regards, |
Thanks for the progress on this! Can you add a CI workflow that tests the code and alerts the developer relations team if it fails, like you did for the bignum example? |
Hi @critesjosh , I've added a nightly test workflow for base64_example following the same format as the other examples. The workflow runs tests on PRs and nightly, and will notify the developer relations team if a nightly run fails. Thanks for your guidance. Thanks. |
HI @critesjosh .Kindly review the changes.
Description
This pull request updates the
lib_examples/base64_example
to compile and work with Noir version 1.0.0-beta.6.The code now uses only the
noir_base64
library, specifically versionv0.4.2
fromhttps://github.com/noir-lang/noir_base64.git
.All previous incompatible dependencies were removed, and the example now runs correctly.
Problem
The existing base64 example could not compile against Noir 1.0.0-beta.6.
It was using outdated libraries and syntax that were incompatible with the latest Noir toolchain.
Summary
Nargo.toml
to usenoir_base64 = {tag = "v0.4.2", git = "https://github.com/noir-lang/noir_base64.git"}
.noir_base64
.Additional Context
See issue #49 for previous discussion and error reports.
After these changes, the example passes compilation and can be executed with both short and long input test cases.
PR Checklist
cargo fmt
on default settings.