refactor buffer storage 4 #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
Merged
Draft
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 18, 2024
Draft
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| private regl: Regl; | ||
| public renderer: ReglRenderer; | ||
| private bufferMap: WeakMap<ArrayBufferView, DS.BufferLocation> = new Map(); | ||
| private bufferMap: WeakMap<ArrayBufferView, DS.BufferLocation<Buffer>> = new Map(); |
There was a problem hiding this comment.
The code initializes a WeakMap but incorrectly uses the Map constructor. To fix the type mismatch, replace new Map() with new WeakMap(). This will ensure the implementation matches the declared type and maintains the intended weak reference behavior.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
This was referenced Dec 20, 2024
bmschmidt
commented
Jan 16, 2025
| byte_size?: number; // in bytes; | ||
| }; | ||
|
|
||
| export type WebGPUBufferLocation = BufferLocation<GPUBuffer> & { |
There was a problem hiding this comment.
This might have to wait if we don't do the webGPU imports.
bmschmidt
commented
Jan 16, 2025
| stride: 4, // meaningless here. | ||
| byte_size: this.buffer_size - this.pointer, | ||
| }); | ||
| console.log("YOOO") |
There was a problem hiding this comment.
Suggested change
| console.log("YOOO") |
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split
branch
from
01d31db to
75c61cc
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split_split
branch
from
7237d17 to
4bb8cf9
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split
branch
from
75c61cc to
bd9f1be
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split_split
branch
from
4bb8cf9 to
61337d0
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split
branch
from
bd9f1be to
c1c0448
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split_split
branch
from
61337d0 to
eef33f1
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split
branch
from
c1c0448 to
e631b9a
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split_split
branch
from
eef33f1 to
38c301d
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split
branch
from
e631b9a to
e10a35d
Compare
bmschmidt
force-pushed
the
12-17-refactor_buffer_storage_split_split_split
branch
from
38c301d to
169b197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes the memory management class used to hold webGL buffers and breaks it into an abstract type and a webGL specific type so that we can re-use the same code later to hold webGPU memory as well.