Skip to content

Conversation

@SINAPSA-IC
Copy link

2024.12.07 - GPT4All v3.4.2x. - Translation into de_DE (German/Deutsch)

Author: Victor Emanuel of SINAPSA Infocomplex (R)(TM)

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Steps to Reproduce

Notes

2024.12.07 - GPT4All v3.4.2x. - Translation into de_DE (German/Deutsch)

Author: Victor Emanuel of SINAPSA Infocomplex (R)(TM)

Signed-off-by: Victor <[email protected]>
@cebtenzzre cebtenzzre requested a review from ThiloteE December 7, 2024 17:29
@cebtenzzre
Copy link
Member

The language lists in CMakeLists.txt and mysettings.cpp will have to be updated in order to add this language.

cebtenzzre and others added 2 commits December 9, 2024 13:16
Signed-off-by: Jared Van Bortel <[email protected]>
2024.12.09
Updated the translation to DEutsch - German

Signed-off-by: Victor <[email protected]>
Copy link
Collaborator

@ThiloteE ThiloteE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am about 1/4th through it. Will need to do more reviews and somebody will have to compile from source eventually to check, if text clashes with GUI. I am currently only looking at the code.

@ThiloteE
Copy link
Collaborator

OMG. all my comments were not saved. T.T I will have to do it again :(
Next time then. Too late for day.

@ThiloteE
Copy link
Collaborator

I was able to review roughly 1/3rd today. Will continue another time.

@SINAPSA-IC
Copy link
Author

SINAPSA-IC commented Dec 14, 2024

Danke sehr. I'll be looking at those^ in the next 2 hours.
You are right - Ruckfall = Fallback (back_ward.en -> zu_rück.de) Aktuelle (Current.en) = Installierte.de (logic-wise) etc

@SINAPSA-IC
Copy link
Author

I wouldn't push the button to sign off and commit, instead I went straight to the file and wrote the changes in there.

<message>
<location filename="../qml/ApplicationSettings.qml" line="413"/>
<source>Enable Datalake</source>
<translation>DataLake aktivieren</translation>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translating "Datalake" as "DatenSee" would very much be viable, but since this is a particular product name that is advertised by Nomic, I will refrain from translating it.

@ThiloteE
Copy link
Collaborator

I am done with my review. There are a few comments still open that refer to to changes in the English base. Would be nice, if somebody from Nomic could address those, but would not prevent a merge from my side.

I hereby approve.

@SINAPSA-IC Thank you for your hard work and effort to provide these langauges! Your contribution is well received.

The review was done with care, but keep in mind, I am not a German/English language expert by profession. Even though German is my native language, sometimes I make mistakes too and the context of where the sentence/words are in the app can have effects on applicable syntax, grammar and vocabulary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants