Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions packages/nx/src/plugins/js/lock-file/pnpm-parser.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1685,4 +1685,84 @@ describe('pnpm LockFile utility', () => {
expect(result).toEqual(expectedPrunedLockFile);
});
});

describe('missing workspace importer', () => {
beforeEach(() => {
const fileSys = {
'node_modules/.modules.yaml': `hoistedDependencies: {}`,
'node_modules/lodash/package.json': '{"version": "4.17.21"}',
};
vol.fromJSON(fileSys, '/root');
});

it('should throw clear error when workspace package importer is missing', () => {
// v9.0 lockfile
// Only has root importer (.)
// Root importer references a workspace package with link:
// But the workspace package's importer is MISSING
const lockFile = `lockfileVersion: '9.0'

importers:

.:
dependencies:
lodash:
specifier: ^4.17.21
version: 4.17.21
my-workspace-lib:
specifier: workspace:*
version: link:packages/my-workspace-lib

packages:

[email protected]:
resolution: {integrity: sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==}

snapshots:

[email protected]: {}`;

const packageJson = {
name: 'test-app',
version: '1.0.0',
dependencies: {
lodash: '^4.17.21',
'my-workspace-lib': 'workspace:*',
},
};

const graph: ProjectGraph = {
nodes: {
'my-workspace-lib': {
name: 'my-workspace-lib',
type: 'lib',
data: {
root: 'packages/my-workspace-lib',
metadata: {
js: {
packageName: 'my-workspace-lib',
},
},
},
},
},
dependencies: {},
externalNodes: {
'npm:lodash': {
type: 'npm',
name: 'npm:lodash',
data: {
version: '4.17.21',
packageName: 'lodash',
hash: 'sha512-v2kDEe57lecTulaDIuNTPy3Ry4gLGJ6Z1O3vE1krgXZNrsQ+LFTGHVxVjcXPs17LhbZVGedAJv8XZ1tvj5FvSg==',
},
},
},
};

expect(() =>
stringifyPnpmLockfile(graph, lockFile, packageJson, '/virtual')
).not.toThrow();
});
});
});
6 changes: 4 additions & 2 deletions packages/nx/src/plugins/js/lock-file/pnpm-parser.ts
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,10 @@ export function stringifyPnpmLockfile(
const workspaceDependencyImporters: Record<string, ProjectSnapshot> = {};
for (const [packageName, importerPath] of Object.entries(requiredImporters)) {
const baseImporter = importers[importerPath];
workspaceDependencyImporters[`workspace_modules/${packageName}`] =
baseImporter;
if (baseImporter) {
workspaceDependencyImporters[`workspace_modules/${packageName}`] =
baseImporter;
}
}

const output: Lockfile = {
Expand Down
Loading