Updated EqualTo constraint #1070
Merged
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanKilleen
reviewed
Sep 12, 2025
docs/articles/nunit/writing-tests/constraints/EqualConstraint.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sean Killeen <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes documentation and code examples for the EqualTo constraint by reorganizing the modifiers list and adding explanation for the IgnoreWhiteSpace modifier.
- Reorganized the modifiers list to remove duplicated entries and improve logical grouping
- Added a code example demonstrating the IgnoreWhiteSpace modifier usage
- Added documentation explaining that IgnoreWhiteSpace uses the same characters as C# Char.IsWhiteSpace
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/snippets/Snippets.NUnit/ConstraintExamples.cs | Added code example showing IgnoreWhiteSpace modifier usage |
| docs/articles/nunit/writing-tests/constraints/EqualConstraint.md | Reorganized modifiers list, removed duplicates, and added IgnoreWhiteSpace explanation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
SeanKilleen
reviewed
Sep 12, 2025
| @@ -44,6 +44,7 @@ public void EqualConstraint_Strings() | |||
| string[] expected = ["Hello", "World"]; | |||
| string[] actual = ["HELLO", "world"]; | |||
| Assert.That(actual, Is.EqualTo(expected).IgnoreCase); | |||
| Assert.That("Hello my world is \r\n on fire!", Is.EqualTo("Hellomy world \r\n is on fire!").IgnoreWhiteSpace); | |||
There was a problem hiding this comment.
Fun to see our own analyzer warnings on the PR here. :) maybe extract this to a variable?
There was a problem hiding this comment.
Just to fool the analyzer ?
Arhell
approved these changes
Sep 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2025
Updated EqualTo constraint fb945da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed list of modifiers, removed duplicated entries
Added code to explain IgnoreWhiteSpace modifier.