Skip to content

Conversation

@Yizack
Copy link

@Yizack Yizack commented Nov 6, 2025

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Hello, this PR helps to make it clear that we know the links constant should be an array of ButtonProps

Added the types to sections where code includes external links (Links, Orientation, Reverse)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Yizack Yizack requested a review from benjamincanac as a code owner November 6, 2025 22:39
@github-actions github-actions bot added the v4 #4488 label Nov 6, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

npm i https://pkg.pr.new/@nuxt/ui@5397

commit: ea0dab5

Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change this indeed but only if it's done in every component for consistency.

@Yizack
Copy link
Author

Yizack commented Nov 7, 2025

We could change this indeed but only if it's done in every component for consistency.

Hello! I thought of doing that too, if you want I can work on checking all components for missing externalTypes, ask you for review when done and rename this PR with a components scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants