Remove useless filtring in events&actions sql #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyh
commented
Nov 3, 2025
| pending_chain | ||
| WHERE 1=1 | ||
| ${ | ||
| // If fromAsNum is not undefined, then we have also set toAsNum and can safely query the range |
Member
Author
There was a problem hiding this comment.
I think these are auto format.
45930
reviewed
Nov 3, 2025
|
|
||
| # docker-compose postgres volumes | ||
| db/ | ||
| /db/ |
Member
Author
There was a problem hiding this comment.
src/db will be ignored without this
| FROM | ||
| blocks b | ||
| INNER JOIN pending_chain ON b.id = pending_chain.parent_id | ||
| AND pending_chain.id <> pending_chain.parent_id |
Collaborator
There was a problem hiding this comment.
I am not confident that this can never be true. I just don't know the Mina spec well enough. What is gained by removing this filter? Is the performance notably better?
Member
Author
There was a problem hiding this comment.
No I don't think the perf would be much better. It's just this logic is very confusing here when I'm reading the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is confirmed by running this on a online archive db: