Skip to content

Conversation

@ar-ibrahim
Copy link
Collaborator

No description provided.

@ar-ibrahim ar-ibrahim self-assigned this Sep 2, 2025
#### Overview
- IMPORTANT: Do not edit the edit file directly, it's large
- OBA terms are compositional, check DOSDP design patterns: `src/patterns/dosdp-patterns/*.yaml`
- Desgin pattern templates are found in `src/patterns/data/default`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Desgin pattern templates are found in `src/patterns/data/default`
- Design pattern templates are found in `src/patterns/data/default`

```
```

2- Check whether design pattern components have been imported to OBA. Search `src/ontology/imports/merged_import.owl`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2- Check whether design pattern components have been imported to OBA. Search `src/ontology/imports/merged_import.owl`
2- Check whether design pattern filler terms have been imported to OBA. Search `src/ontology/imports/merged_import.owl`

sh run.sh make IMP=false MIR=false ../patterns/definitions.owl

5- Refresh OBA imports by running
sh run.sh make refresh-merged
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope this will work but it might.. run out memory?


6 - Run sh run.sh make IMP=false MIR=false ../patterns/definitions.owl again.

7- When creating new OBA terms using DOSDP patterns, it may be necessary to import terms from other ontologies like ChEBI, the Chemical Entities of Biological Interest or PRO, the PRotein Ontology. However, they are too large to be managed as standard imports so are managed as slims. When a new term you are using in a DOSDP pattern is not yet in a slim you will have to refresh the slim first. They are located here:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a term does not exist in pro_obo_slim, ncbitaxon or chebi_obo_slim, make a comment in the issue asking these terms to be added manually.


## Handling GitHub issues and requests
- Use `gh` to read and write issues/PRs
- Sign all commits and PRs as `@dragon-ai-agent`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Sign all commits and PRs as `@dragon-ai-agent`

uses: actions/cache@v4
with:
path: ~/.jar-cache
key: ${{ runner.os }}-robot-v1.9.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not the latest robot;

your instruction above use ODK, so I dont know if you need to install ROBOT here.. maybe do


cd PATH-TO/bio-attribute-ontology/src/ontology
sh run.sh make ../patterns/definitions.owl
sh run.sh make components/obsoletes.owl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sh run.sh make components/obsoletes.owl
make components/obsoletes.owl

Remove run.sh and see if ROBOT alone works for this (the robot instealled in the setup steps). Ask me if any problems.

@ar-ibrahim ar-ibrahim marked this pull request as ready for review September 30, 2025 14:04
- update AI agent signature
uses: actions/cache@v4
with:
path: ~/.jar-cache
key: ${{ runner.os }}-robot-v1.9.7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: ${{ runner.os }}-robot-v1.9.7
key: ${{ runner.os }}-robot-v1.9.8

run: |
mkdir -p ~/.jar-cache
if [ ! -f ~/.jar-cache/robot.jar ]; then
curl -L https://github.com/ontodev/robot/releases/download/v1.9.7/robot.jar -o ~/.jar-cache/robot.jar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -L https://github.com/ontodev/robot/releases/download/v1.9.7/robot.jar -o ~/.jar-cache/robot.jar
curl -L https://github.com/ontodev/robot/releases/download/v1.9.8/robot.jar -o ~/.jar-cache/robot.jar

- name: Setup ROBOT tools
run: |
cp ~/.jar-cache/robot.jar ${{ github.workspace }}/tools/robot.jar
curl -L https://raw.githubusercontent.com/ontodev/robot/v1.9.7/bin/robot -o ${{ github.workspace }}/tools/robot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -L https://raw.githubusercontent.com/ontodev/robot/v1.9.7/bin/robot -o ${{ github.workspace }}/tools/robot
curl -L https://raw.githubusercontent.com/ontodev/robot/v1.9.8/bin/robot -o ${{ github.workspace }}/tools/robot

- Updated to latest version of robot.
- `obo-grep.pl -r 'OBA_2040177' src/patterns/definitions.owl`
- Note that `obo-grep.pl` is in your PATH, no need to search for it
- Only search over `src/patterns/definitions.owl`
- DO NOT bother doing your own greps over the file, or looking for other files, unless otherwise asked, you will just waste time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OBA has a different system than other ontologies, so it might be useful that copilot looks at other files, such as as the DOSDP yaml files or tsv tables, specially if the idea is to provide only a label and it recognizes which pattern should it use. However, it doesn't need grep for it.


Example 3: A trait that affects the response to prednisolone. Use the design pattern template `response_to_chemical_stimulus_trait.tsv` and the filler term: prednisolone.

2- Check whether design pattern fillers have been imported to OBA. Search `src/ontology/imports/merged_import.owl`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a large file, maybe here it needs grep?

3- If they have been imported, please proceed to creating the new OBA term using the appropriate DOSDP pattern template.

4- Add the term to the template, then run
make IMP=false MIR=false ../patterns/definitions.owl
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be added as a command format (use ` before and after the code, or ```)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment for points 5 and 6

- Each term requires: id, name, definition with references
- Never guess OBA IDs, or ontology term IDs, use search tools above to determine actual term
- Never guess PMIDs for references, do a web search if needed
- Use standard relationship types: is_a, part_of, has_part, etc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add usual OBA relations

## Obsoleting terms originating from DOS-DP templates

- Delete the row with the targeted term from the appropriate data table (tsv file) in folder: src/patterns/data/default/
- Fill in the IRI of the term to be obsoleted in src/templates/obsoletes.tsv along with other relevant information. It is useful add a comment with an explanation for the obsoletion. Start the comment with 'Reason for obsoletion: '.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might need an example or some more information


## Other metadata

- Link back to the issue you are dealing with using the `term_tracker_item`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does OBA include this?


- Link back to the issue you are dealing with using the `term_tracker_item`
- All terms should have definitions, with at least one definition xref, ideally a PMID
- You can sign terms as `created_by: AI agent`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be in a column of the DOSDP

@ar-ibrahim ar-ibrahim requested a review from aleixpuigb October 22, 2025 09:40
Removed troubleshooting instructions
@jamesamcl jamesamcl merged commit f21aacd into master Oct 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants