-
Notifications
You must be signed in to change notification settings - Fork 450
Allow running tests concurrently with watch server, again! #12473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ElectreAAS
merged 3 commits into
ocaml:main
from
ElectreAAS:test-concurrent-with-watch-mode
Oct 14, 2025
Merged
Allow running tests concurrently with watch server, again! #12473
ElectreAAS
merged 3 commits into
ocaml:main
from
ElectreAAS:test-concurrent-with-watch-mode
Oct 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectreAAS
commented
Sep 17, 2025
fec9cf9
to
f20ddb3
Compare
009a1ff
to
ccc3909
Compare
ElectreAAS
commented
Sep 30, 2025
c4ba736
to
27412bc
Compare
OutdatedThe last commit (27412bc) is maybe a bit overzealous in the refactoring, but that was the only way I found to make sure the error messages were correct. Up to dateI just force-pushed a few changes:
It's now both ready to review and reviewable! 😃 PS: the previous state of this PR is still visible on my fork, as a backup |
27412bc
to
7d000a2
Compare
Alizter
reviewed
Oct 13, 2025
test/blackbox-tests/test-cases/watching/watching-eager-concurrent-build-command.t
Outdated
Show resolved
Hide resolved
7d000a2
to
6cb1657
Compare
Alizter
approved these changes
Oct 13, 2025
Signed-off-by: Ambre Austen Suhamy <[email protected]>
Signed-off-by: Ambre Austen Suhamy <[email protected]>
6cb1657
to
4a28f9c
Compare
This was referenced Oct 14, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed to #8114
Supersedes #11900.
This PR is a 'remake' of Steve's: I rebased it on main, and applied what I learned making #12010 and #12064. This results in significant changes from the original, hence the new PR.
The 'runtest' RPC request is now public, in otherlibs.
runtest_rpc.ml{i}
was removed.The behaviour is now (AFAI know what I'm doing) identical between running
dune runtest [ARGUMENTS]
with or without the RPC server.See comments below for details