Skip to content

Conversation

@duducpp
Copy link

@duducpp duducpp commented Apr 28, 2025

Resolves #698


Before the change?

  • In case we send a exp more than 10minutes in future github responds with a 401 error which is not handled

After the change?

  • If github responds with 'Expiration time' claim ('exp') is too far in the future' we regenerate the token using github date from response

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@duducpp duducpp force-pushed the fix/exp-is-too-far-in-the-future branch from b011db4 to 487b03a Compare April 28, 2025 13:28
@nickfloyd nickfloyd moved this from 🆕 Triage to 👀 In review in 🧰 Octokit Active Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

[BUG]: 'Expiration time' claim ('exp') is too far in the future

1 participant