Skip to content

Conversation

edgarrmondragon
Copy link
Contributor

With the recommendation that developers start testing their applications during the RC phase of CPython, I think this makes sense but this doesn't make 3.14 the default yet.

Let me know if you agree or if we should wait for the final 3.14.0 release.

@edgarrmondragon
Copy link
Contributor Author

Ok, I see #210. Thanks @ofek!

@ofek
Copy link
Owner

ofek commented Oct 15, 2025

Oh no Edgar, I totally forgot about this PR! One sec, let me see if I can fix this somehow.

@ofek
Copy link
Owner

ofek commented Oct 15, 2025

dc9ca39 (#211) 😄

I had to remove the version bump in the docs CI because there was an error which I didn't have time to investigate https://github.com/ofek/pyapp/actions/runs/18519887611/job/52777390971?pr=211

@ofek
Copy link
Owner

ofek commented Oct 15, 2025

Confirmed that the attribution mechanism persists after merging!

image

Sorry about missing your PR, feel free to bump PRs or issues whenever you wish so that I have a better chance of remembering 😅


# Skip prereleases for now
if version.pre is not None:
if version.pre is not None and version.pre[0] != 'rc':
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was back when 3.14 was still in the RC phase, so this made sure it wasn't skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants