Skip to content

Fix errors when a grouped table is shown #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix errors when a grouped table is shown #4672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e51fca2
- fix horizontal scrollbar showing on initial display if there are gr…
janhaertel Jan 23, 2025
1b49e12
- fix tableholder not scrolling to bottom if there are groups
janhaertel Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/js/core/RowManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,11 @@ export default class RowManager extends CoreFeature{
}

this.layoutRefresh(true);

// handle resized columns
if(this.table.modExists("groupRows")) {
this.table.modules.groupRows.virtualRenderFill();
Copy link
Collaborator

@azmy60 azmy60 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do this inside the GroupRows module? Just making sure that we are isolating group rows related codes within its own module.

You can probably subscribe to a table-layout event from the GroupRows module and see if that works. If not, please let me know, and we can figure something out.

}
}
}else{
this.renderEmptyScroll();
Expand Down
4 changes: 3 additions & 1 deletion src/js/modules/GroupRows/Group.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,9 @@ export default class Group{

reinitializeHeight(){}

calcHeight(){}
calcHeight(){
this.outerHeight = this.element.offsetHeight;
}

setCellHeight(){}

Expand Down