Fix: Refine row click behavior for selection and deselection #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When multiple rows are selected using SHIFT + click, clicking on an individual row within that selection did not deselect it. This commit modifies the `handleComplexRowClick` function in the `SelectRow` module to correctly handle this scenario. Now, clicking an already selected row will deselect it, regardless of how it was initially selected.
edmundophie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address an issue reported in #4442
Current State
Expected State
Description
This PR tries to achieve the following behavior when a row is clicked without SHIFT/CTRL:
This commit modifies the
handleComplexRowClickfunction in theSelectRowmodule to correctly handle this scenario. Now, clicking an already selected row will deselect it, only if only it was the only one being selected previously.