Replace commons.lang by commons.lang3 #105
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbesson
requested changes
Jul 31, 2025
There was a problem hiding this comment.
I suspect part of the issue (and the reason why the builds starting failing) is that this library was not explicitly declaring a direct dependency and relying on the transitive dependency from Bio-Formats. Similarly to https://github.com/ome/omero-romio/blob/dd94b039abd0e7be6399cc25a4dbc84e85099ac5/build.gradle#L25, build.gradle should be updated accordingly.
Overall, I am fully supportive of moving from commons-lang to commons-lang3 across the omero-* components for the same rationale as in ome/bioformats#4343.
dominikl
approved these changes
Jul 31, 2025
sbesson
approved these changes
Aug 1, 2025
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build failure noticed in merge-ci is due to the recent version bump in Bio-Formats
see ome/bioformats#4343