Test: Add test cases to verify VR configuration and FanTable firmware… #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubskmr
reviewed
Sep 8, 2025
Comment on lines
321
to
323
| if (count > 0) { | ||
| is_fantable_supported = true; | ||
| LOG_INFO << "Fan table handles are available on this device!"; |
There was a problem hiding this comment.
firmware handle count will be >0 even in cases when fan table is not supported. This check is not correct to decide fan table support. We should check the properties like how you have done in line 330
shubskmr
requested changes
Sep 8, 2025
Comment on lines
+373
to
+374
| if (count > 0) { | ||
| is_VRConfig_supported = true; | ||
| LOG_INFO << "VR Config handles are available on this device!"; |
There was a problem hiding this comment.
same here this is not correct
| zes_firmware_properties_t props = { | ||
| ZES_STRUCTURE_TYPE_FIRMWARE_PROPERTIES}; | ||
| zesFirmwareGetProperties(fw_handle, &props); | ||
| if (std::string(props.name) == "FanTable") { |
There was a problem hiding this comment.
Why FanTable in VR config test?
sandhya-c
force-pushed
the
level_zero_tests_Late_binding
branch
from
5c88341 to
b03b128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… flashing