Support for ZEL_DRIVERS_ORDER to order based off user input #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nrspruit
force-pushed
the
drivers_order_support
branch
3 times, most recently
from
8eae576 to
f9f1122
Compare
nrspruit
force-pushed
the
drivers_order_support
branch
from
f9f1122 to
a9b9a77
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
drivers_order_support
branch
from
a9b9a77 to
d76cae1
Compare
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
Signed-off-by: Neil R. Spruit <[email protected]>
rwmcguir
reviewed
Sep 17, 2025
| return loader::ZEL_DRIVER_TYPE_FORCE_UINT32; // Invalid | ||
| } | ||
|
|
||
| // Helper function to trim whitespace (copy from implementation) |
There was a problem hiding this comment.
Very Minor: In the future, would it would make more sense to have a util.h or something with these things defined, since we're duplicating functions between code bodies.
Signed-off-by: Neil R. Spruit <[email protected]>
nrspruit
force-pushed
the
drivers_order_support
branch
from
0ef96a5 to
d9a64e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.