Skip to content

Change the way to validate keep_num_dims attribute for new tf. #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Change the way to validate keep_num_dims attribute for new tf. #2367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b863e22
Change the way to validate keep_num_dims attribute for new tf.
fatcat-z Nov 20, 2024
97cb453
Fix a lint issue.
fatcat-z Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions tf2onnx/tflite_handlers/tfl_math.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,12 +201,10 @@ def to_tf(cls, ctx, node, **kwargs):
separate_fused_activation_function(ctx, node)
utils.make_sure(node.attr['weights_format'].s == b'DEFAULT',
"Only default weights format supported for fully connected op")
utils.make_sure(node.attr['keep_num_dims'].i == 0,
"Only keep_num_dims=False supported for fully connected op")
if node.attr['asymmetric_quantize_inputs'].i == 1:
dynamic_quantize_inputs(ctx, node)

if ctx.get_rank(node.input[0]) != 2:
if node.attr['keep_num_dims'].i == 0 and ctx.get_rank(node.input[0]) != 2:
# When a fullyconnected node has keep_num_dims=0 and input[0] rank > 2, the extra dims must be compressed
utils.make_sure(ctx.get_rank(node.input[1]) == 2, "weights for FullyConnected must have rank 2")
weights_shape = ctx.get_shape(node.input[1])[1]
Expand Down
Loading