Support DFT-17 #2417
Draft
Support DFT-17 #2417
+203
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
justinchuby
commented
Nov 3, 2025
| consumer_types == {'ComplexAbs'}, | ||
| "Current implementation of RFFT2D only allows ComplexAbs as consumer not %r", | ||
| consumer_types in [{'ComplexAbs'}, {'Squeeze'}], | ||
| "Current implementation of RFFT2D only allows ComplexAbs or Squeeze as consumer not %r", |
There was a problem hiding this comment.
You would need to add more unit tests to check this is working. The current code assumes complex produced FFT are converted into real numbers soon after.
There was a problem hiding this comment.
Yeah - this change is incorrect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.