Skip to content

Conversation

@mdsiddiq-till
Copy link
Contributor

@mdsiddiq-till mdsiddiq-till commented Jul 8, 2025

Description

Add more conditional operators

  • attribute_exists
  • attribute_not_exists

Related Issues

Issue: https://oolio.atlassian.net/browse/OC-4926

How Has This Been Tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Screenshots (if appropriate)

Comment on lines 41 to 42
} else if (operator=== 'ATTRIBUTE_EXISTS' || operator === 'ATTRIBUTE_NOT_EXISTS') {
expression += `${operator.toLowerCase()}(${expressionName})`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this extension for any other PR yet to create?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
Coming pr in POS

adityanagar10
adityanagar10 previously approved these changes Jul 8, 2025
Santosh1608
Santosh1608 previously approved these changes Jul 8, 2025
adityanagar10
adityanagar10 previously approved these changes Jul 8, 2025
Santosh1608
Santosh1608 previously approved these changes Jul 8, 2025
Santosh1608
Santosh1608 previously approved these changes Jul 8, 2025
quangthanh0909
quangthanh0909 previously approved these changes Jul 8, 2025
Copy link
Contributor

@quangthanh0909 quangthanh0909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shidil shidil dismissed stale reviews from quangthanh0909 and Santosh1608 September 17, 2025 08:13

Failing tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants