Skip to content

Conversation

@larshp
Copy link
Member

@larshp larshp commented Oct 23, 2025

No description provided.

@larshp larshp changed the title fix cl_json fix cl_json Oct 23, 2025
@github-actions
Copy link

Performance test results:

Performance Before After Delta
CL_CONVERSION_EXIT_INPUT 893ms 941ms 48 🟢
CL_JSON_PARSING1 1493ms 1622ms 129 🟢
CL_UI2_DESERIALIZE1 392ms 459ms 67 🟢
CL_UI2_SERIALIZE1 176ms 204ms 28 🟢

Updated: 2025-10-23T11:26:21.901Z

SHA: 92155a6

@larshp larshp requested a review from Copilot October 23, 2025 11:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the pretty_name_mode type and related constants in the /ui2/cl_json class to use a more efficient single-character representation instead of strings. The change standardizes the type usage across all method signatures that accept pretty_name parameters.

Key Changes:

  • Changed pretty_name_mode from string to single-character type (c LENGTH 1)
  • Updated constant values to use single characters ('L' for low_case, 'X' for camel_case)
  • Enforced type consistency across all method signatures using pretty_name parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@larshp larshp marked this pull request as ready for review October 23, 2025 11:28
@larshp larshp merged commit d65f340 into main Oct 23, 2025
7 checks passed
@larshp larshp deleted the hvam/fixcl_json2310 branch October 23, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants