Skip to content

fix: Pin byte-buddy(-agent) version to 1.14.19 to workaround Mockito issue #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 22, 2024
Merged

fix: Pin byte-buddy(-agent) version to 1.14.19 to workaround Mockito issue #1060

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a75e705
fix: Add the net.bytebuddy.experimental=true system property
ryanprayogo Aug 21, 2024
21593e4
fix: Pin byte-buddy and byte-buddy-agent to a newer version
ryanprayogo Aug 22, 2024
28d83f2
chore: Fix maven warning about deprecated expression
ryanprayogo Aug 22, 2024
dbaeddf
chore: Add comments around the Mockito workaround
ryanprayogo Aug 22, 2024
5cf2287
Update pom.xml
toddbaert Aug 22, 2024
81cc56f
Merge branch 'main' into fix-1059
toddbaert Aug 22, 2024
d4485cc
Merge branch 'main' into fix-1059
toddbaert Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<junit.jupiter.version>5.11.0</junit.jupiter.version>
<!-- exclusion expression for e2e tests -->
<testExclusions>**/e2e/*.java</testExclusions>
<module-name>${groupId}.${artifactId}</module-name>
<module-name>${project.groupId}.${project.artifactId}</module-name>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing maven warnings

[WARNING] The expression ${groupId} is deprecated. Please use ${project.groupId} instead.
[WARNING] The expression ${artifactId} is deprecated. Please use ${project.artifactId} instead.

</properties>

<name>OpenFeature Java SDK</name>
Expand Down Expand Up @@ -151,6 +151,24 @@
<dependencyManagement>
<dependencies>

<!-- Start mockito workaround -->
<!-- https://github.com/mockito/mockito/issues/3121 -->
<!-- These are transitive dependencies of mockito we are forcing -->
<dependency>
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy</artifactId>
<version>1.14.19</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy-agent</artifactId>
<version>1.14.19</version>
<scope>test</scope>
</dependency>
<!-- End mockito workaround-->

<dependency>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-bom</artifactId>
Expand Down
Loading