COLL/UCC: add persistent collective calls for UCC #13374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 21, 2025 14:33
Signed-off-by: hasegawa.kento <[email protected]>
Signed-off-by: hasegawa.kento <[email protected]>
Signed-off-by: hasegawa.kento <[email protected]>
bosilca
reviewed
Aug 22, 2025
There was a problem hiding this comment.
I have few nitpick comments for the entire commit:
- 'iniz' has little meaning. How about init_common instead ?
- 'a' as a siffix has no meaning while ' alias' does !
- in the original code when the call to the UCC collective _init was made it was multiline with clear separation between send and receive argument. Please maintain that structure, and add the persistent bool flag in front of the ucc_module.
bosilca
reviewed
Aug 22, 2025
| @@ -592,6 +648,19 @@ OBJ_CLASS_INSTANCE(mca_coll_ucc_req_t, ompi_request_t, | |||
|
|
|||
| int mca_coll_ucc_req_free(struct ompi_request_t **ompi_req) | |||
| { | |||
| if (MPI_REQUEST_NULL != ompi_req[0]) { | |||
There was a problem hiding this comment.
I'm mostly certain that this function cannot be called with MPI_REQUEST_NULL, as MPI_REQUEST_NULL is a static object and cannot be added on any free_list. Did you see it happening ? If not please remove this protection.
bosilca
reviewed
Aug 22, 2025
| UCC_ERROR("ucc_collective_post failed: %s", ucc_status_string(rc_ucc)); | ||
| coll_req->super.req_complete = REQUEST_COMPLETED; | ||
| coll_req->super.req_state = OMPI_REQUEST_INACTIVE; | ||
| if (OMPI_SUCCESS == rc) { |
There was a problem hiding this comment.
please ensure that coll_req->super.req_status.MPI_ERROR reflect the rc error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In addition to the existing blocking and non-blocking collective calls,
this PR adds persistent collective call in COLL/UCC.
For example,
How
This adds <coll>_init function for each collective operation,
using UCC_COLL_ARGS_FLAG_PERSISTENT flag [1].
Reference
[1] "Unified Collective Communications (UCC) Specification Version 1.0" (2022/02/18)
https://openucx.github.io/ucc/api/v1.0/pdf/ucc.pdf
- UCC_COLL_ARGS_FLAG_PERSISTENT in Section 8.8.4.2 "ucc_coll_args_flags_t"