[receiver/kafka] add support for max partition fetch bytes config #43105
+47
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Dias <[email protected]>
Signed-off-by: Paulo Dias <[email protected]>
paulojmdias
requested review from
MovieStoreGuy,
axw and
a team
as code owners
VihasMakwana
reviewed
Oct 1, 2025
Co-authored-by: Vihas Makwana <[email protected]>
VihasMakwana
reviewed
Oct 1, 2025
| - `default_fetch_size` (default = `1048576`): The default number of message bytes to fetch in a request, defaults to 1MB. | ||
| - `max_fetch_size` (default = `0`): The maximum number of message bytes to fetch in a request, defaults to unlimited. | ||
| - `max_fetch_wait` (default = `250ms`): The maximum amount of time the broker should wait for `min_fetch_size` bytes to be available before returning anyway. | ||
| - `max_partition_fetch_size` (default = `1048576`): The default number of message bytes to fetch in a request per partition, defaults to 1MB. If a single record batch is larger than this value, the broker will still return it to ensure the consumer can make progress. This setting only applies while using [`franz-go`](https://github.com/twmb/franz-go). |
There was a problem hiding this comment.
A thing we can work as a follow-up is to use human readable formats in documentation.
We can use 1 MiB instead of 1048576
There was a problem hiding this comment.
Not a necessity for this PR as there few more places in this README.
There was a problem hiding this comment.
@VihasMakwana I opened a new issue for this and other components.
VihasMakwana
approved these changes
Oct 1, 2025
VihasMakwana
added
the
ready to merge
|
Good to merge, as it is approved by codeowner! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a new setting named
max_partition_fetch_sizeto be used withkgo.FetchMaxPartitionBytesfranz-go option.Link to tracking issue
Fixes #43097
Testing
Updated tests to ensure the new config is applied and works as expected.
Documentation
Documentation updated with the new setting, and referencing will only work while using
franz-goas Sarama doesn't have support for it.