Gradle plugin for generating weaver files #2413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🔧 The result from spotlessApply was committed to the PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at creating a gradle plugin to replace the makefiles for the weaver generation tasks, inspired by the semantic-conventions-java approach
I imagine this will need to evolve as we figure out the needs of running it for multiple modules (like #2362), aside from just the ibm-mq-metrics, which this was mostly focused on solving for.
I'm still not sure if this is the best approach, there are some others that are still being discussed in open-telemetry/weaver#792 but wanted to see what this might look like
cc @atoulme