-
Notifications
You must be signed in to change notification settings - Fork 601
fix: Enable union type support in @opentelemetry/instrumentation-graphql (#1506) #2923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Enable union type support in @opentelemetry/instrumentation-graphql (#1506) #2923
Conversation
Hi @nitrofski and thanks for your contribution. I order to proceed we need a couple of things:
Cheers |
@obecny can you please take a look at this? |
I merged with main. There are issues with CLA approval at my company at the moment, which we are working on getting resolved. I will sign as soon as that's done. Sorry for the delay. |
CLA issues have been resolved. |
@obecny can you please take a look at this? |
Good day, This hasn't seen feedback in over a month. Is there anything I can do to help get attention on this PR? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2923 +/- ##
=======================================
Coverage 91.44% 91.45%
=======================================
Files 146 146
Lines 8194 8202 +8
Branches 1846 1848 +2
=======================================
+ Hits 7493 7501 +8
Misses 701 701
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Which problem is this PR solving?
Fixes #1506.
Short description of the changes
Enable support for installing field instrumentation on union types.
The "type unwrap" logic was generalized to support unwrapping to a list of types. It is now a recursive function rather than a loop. The new unwrapping has been implemented in a way that is more agreeable to TypeScript.