-
Notifications
You must be signed in to change notification settings - Fork 601
feat(instrumentation-koa): Add support for koa 3 #2957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(instrumentation-koa): Add support for koa 3 #2957
Conversation
b499b4b
to
bdcd88a
Compare
I wasn't sure of the release process and if I needed to also change the manifest file or not. |
This package does not have an assigned component owner and is considered unmaintained. As such this package is in feature-freeze and this PR will be closed with 14 days unless a new owner or a sponsor (a member of @open-telemetry/javascript-approvers) for the feature is found. It is the responsibility of the author to find a sponsor for this feature. |
@seemk @JacksonWeber are either of you interested in becoming component owner here? |
1e36d6a
to
487143e
Compare
I went ahead and applied the requested changes. |
@@ -13,6 +13,6 @@ | |||
koa: | |||
# Testing ^2.7.0 covers at least 97% of the downloaded koa versions | |||
versions: | |||
include: "^2.7.0" | |||
include: "^3.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change only v3 and up are going to be tested. So we won't know if this instrumentation is still compatible with the ^2.7.0
range because it wont be tested anymore.
include: "^3.0.1" | |
include: ">=2.7.0 <4" |
Thanks for contributing to OpenTelemetry. And sorry for getting here after 3 weeks. I'll have this PR in my radar from now on. Please resolve the conflicts and read my comments |
I sponsor this PR. |
@david-luna I went ahead and made the requested changes. I wasn't exactly sure the best way to not run the test in 3.0 but let me know what you think. Thanks! |
2512466
to
76e1b10
Compare
76e1b10
to
795babd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 146 146
Lines 8192 8193 +1
Branches 1846 1848 +2
=======================================
+ Hits 7491 7492 +1
Misses 701 701 Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Which problem is this PR solving?
Short description of the changes