chore(opentelemetry-sampler-aws-xray): Move X-Ray Sampler out of Incubating #2993
+155
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2993 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 146 146
Lines 8194 8194
Branches 1846 1846
=======================================
Hits 7493 7493
Misses 701 701 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
4 tasks
|
I need review from @open-telemetry/javascript-approvers to move this component out of incubating for public release. |
pichlermarc
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
thank you @jj22ee - please resolve the conflicts, then we can get this merged 🙂
trentm
reviewed
Sep 10, 2025
jj22ee
force-pushed
the
move-xray-sampler-to-packages
branch
from
727538c to
10e9b6e
Compare
|
Thanks! Resolved the conflicts and also updated initial version to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
v1.1+packages/sampler-aws-xray/package.jsonto compile using bothtsconfig.jsonandtsconfig.esm.json, and to be publicly accessible and not private for release.release-pleaserelated files to include X-Ray Sampler.