feat(instrumentation-langchain): Add LangChain.js instrumentation skeleton #3024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctually updating the package-lock.json. Just copied over all the dependencies and file structure of my already implemented project
yiyuan-he
reviewed
Sep 8, 2025
There was a problem hiding this comment.
Thanks for breaking down the original PR. We can probably do without all the placeholder files with just the license info for now as well.
There was also this PR which was merged recently which I believe is the first GenAI-related package in this repo. Have you had a chance to take a look at it to ensure we are following the same patterns/precedents?
yiyuan-he
reviewed
Sep 8, 2025
| @@ -66,6 +66,9 @@ components: | |||
| # Unmaintained | |||
| packages/instrumentation-kafkajs: | |||
| - seemk | |||
| packages/instrumentation-langchain: | |||
There was a problem hiding this comment.
Consider also adding @mxiamxia as codeowner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes