Add severity-based and trace-based log record processors #4611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
severity-and-trace-based-log-processors
branch
from
ca86d92 to
a5e39f1
Compare
pellared
reviewed
Jul 31, 2025
pellared
reviewed
Jul 31, 2025
cijothomas
reviewed
Jul 31, 2025
cijothomas
reviewed
Jul 31, 2025
specification/logs/sdk.md
Outdated
| and return `true` if not available. | ||
| * [`OnEmit`](#onemit) - If the log record is associated with a valid span | ||
| context that is not sampled, MUST NOT forward it to the delegate. Otherwise, MUST | ||
| forward the log record to the delegate. |
There was a problem hiding this comment.
nit: Could we update the desc of this to make it more obvious that if the log is emitted outside any active spans, then they are not subject to filtering?
cijothomas
reviewed
Jul 31, 2025
trask
force-pushed
the
severity-and-trace-based-log-processors
branch
from
7dc4d37 to
f0f47fa
Compare
pellared
reviewed
Jul 31, 2025
|
Based on discussion in today's spec SIG meeting, I am going to proceed with #4612 instead |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 23, 2025
…ers (#4612) Alternative to #4611 Some related prior discussions: - #4208 (comment) - #4207 (comment) Java POC @ open-telemetry/opentelemetry-java#7529 Declarative config for this is a bit nicer than in #4611, also supports applying different minimum severity levels to different loggers: ``` file_format: "1.0" logger_provider: logger_configurator/development: default_config: minimum_severity: WARN trace_based: true loggers: - name: "com.example.app.*" config: minimum_severity: INFO - name: "com.example.db.*" config: minimum_severity: ERROR ``` --------- Co-authored-by: Liudmila Molkova <[email protected]> Co-authored-by: Robert Pająk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See alternative in #4612
Some related prior discussions:
Java POC @ open-telemetry/opentelemetry-java#7520
Here's an example of how it would look like to use both of these in declarative configuration: