Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Sep 29, 2025

Changes

This splits the attribute tables based on the deprecation status.

This provides the following benefits:

  • deprecated attributes no longer needs to be moved to seperate groups simplifying process and improving history
  • The attributes on signals are grouped the same as the registry
  • The deprecated tables can have a different structure with links to new attributes

Outstanding tasks:

  • consolidating deprecated attributes in to main file
  • Putting informative briefs back on attributes rather than deprecation reason.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@trask
Copy link
Member

trask commented Oct 13, 2025

consolidating deprecated attributes in to main file

There are pros and cons to having a single yaml for both deprecated and non-deprecated attributes

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 29, 2025
@thompson-tomo thompson-tomo force-pushed the chore/splitDeprecateAttributes branch from 9065cb3 to 5187b63 Compare October 30, 2025 04:24
@github-actions
Copy link

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

  • android

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@thompson-tomo
Copy link
Contributor Author

@joaopgrassi can you reopen, when I reverted the changes I missed a carriage return.

Also shouldn't android be owned by mobile/client sig etc?

@joaopgrassi
Copy link
Member

joaopgrassi commented Oct 30, 2025

I'm sorry but did we discussed this change? I'm not aware that we wanted to do any of these changes. Where did the need of this came from? I think such changes needs to be discussed and agreed first before we start sending PRs.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Oct 30, 2025

Yes it was discussed when we discussed the changes to the attribute tables. The feedback was to avoid needing to update the yaml which is what I have done.

By having a different layout for deprecated we can hide irrelevant columns or even add additional. That is what has been done here.

Note when a deprecated is rendered on a signal it can now have a clickable link to the replacement. This logic could be added to the table in the attribute registry.

Anyway it won't be possible to re-open due to force pushing the typo fix. So have #3016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants