-
Notifications
You must be signed in to change notification settings - Fork 278
[chore] Automatically split attribute tables based on deprecation status #2819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Automatically split attribute tables based on deprecation status #2819
Conversation
6f80fdb to
68a2c9b
Compare
68a2c9b to
9065cb3
Compare
There are pros and cons to having a single yaml for both deprecated and non-deprecated attributes |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
9065cb3 to
5187b63
Compare
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
@joaopgrassi can you reopen, when I reverted the changes I missed a carriage return. Also shouldn't android be owned by mobile/client sig etc? |
|
I'm sorry but did we discussed this change? I'm not aware that we wanted to do any of these changes. Where did the need of this came from? I think such changes needs to be discussed and agreed first before we start sending PRs. |
|
Yes it was discussed when we discussed the changes to the attribute tables. The feedback was to avoid needing to update the yaml which is what I have done. By having a different layout for deprecated we can hide irrelevant columns or even add additional. That is what has been done here. Note when a deprecated is rendered on a signal it can now have a clickable link to the replacement. This logic could be added to the table in the attribute registry. Anyway it won't be possible to re-open due to force pushing the typo fix. So have #3016 |
Changes
This splits the attribute tables based on the deprecation status.
This provides the following benefits:
Outstanding tasks:
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]