-
Notifications
You must be signed in to change notification settings - Fork 654
MIFOSAC-552 Implement Settings Step for New Recurring Deposits Account Flow #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
c721f03
f36b374
f6451c8
c95396f
8d71c75
142f37c
acf6209
e1f16fb
1a40db7
acd510a
57eb5cc
09c4ba1
0ccaf11
cb277b8
be3bb4e
71d3b57
d22f064
cb2c4a8
7fa9360
c2ec400
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,39 @@ | ||||||
| <?xml version="1.0" encoding="utf-8"?> | ||||||
| <!-- | ||||||
| Copyright 2024 Mifos Initiative | ||||||
| This Source Code Form is subject to the terms of the Mozilla Public License, v. 2.0. | ||||||
| If a copy of the MPL was not distributed with this file, | ||||||
| You can obtain one at https://mozilla.org/MPL/2.0/. | ||||||
| See https://github.com/openMF/android-client/blob/master/LICENSE.md | ||||||
| --> | ||||||
| <resources> | ||||||
| <string name="feature_recurringDeposit_step_details">Details</string> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the convention followed for modules names with two words.
Suggested change
|
||||||
| <string name="feature_recurringDeposit_step_terms">Terms</string> | ||||||
| <string name="feature_recurringDeposit_step_settings">Settings</string> | ||||||
| <string name="feature_recurringDeposit_step_interest">Interest</string> | ||||||
| <string name="feature_recurringDeposit_step_charges">Charges</string> | ||||||
| <string name="feature_recurringDeposit_create_recurring_deposit_account">Create Recurring Deposit Account</string> | ||||||
| <string name="feature_recurringDeposit_is_mandatory_deposit">Is Mandatory Deposit?</string> | ||||||
| <string name="feature_recurringDeposit_adjust_advance_payments">Adjust advance payments toward future installments?</string> | ||||||
| <string name="feature_recurringDeposit_allow_withdrawals">Allow Withdrawals?</string> | ||||||
| <string name="feature_recurringDeposit_lock_in_period">Lock-in Period</string> | ||||||
| <string name="feature_recurringDeposit_frequency">Frequency</string> | ||||||
| <string name="feature_recurringDeposit_type">Type</string> | ||||||
| <string name="feature_recurringDeposit_recurring_deposit_details">Recurring Deposit Details</string> | ||||||
| <string name="feature_recurringDeposit_recurring_deposit_amount">Recurring Deposit Amount</string> | ||||||
| <string name="feature_recurringDeposit_deposit_period">Deposit Period</string> | ||||||
| <string name="feature_recurringDeposit_deposit_frequency_same_as_meeting">Deposit Frequency Same as Group/Center meeting</string> | ||||||
| <string name="feature_recurringDeposit_minimum_deposit_term">Minimum Deposit Term</string> | ||||||
| <string name="feature_recurringDeposit_in_multiples_of">And thereafter, in Multiples of</string> | ||||||
| <string name="feature_recurringDeposit_maximum_deposit_term">Maximum Deposit Term</string> | ||||||
| <string name="feature_recurringDeposit_for_pre_mature_closure">For Pre-mature closure</string> | ||||||
| <string name="feature_recurringDeposit_apply_penal_interest">Apply Penal Interest (less)</string> | ||||||
| <string name="feature_recurringDeposit_penal_interest_percentage">Penal Interest (%)</string> | ||||||
| <string name="feature_recurringDeposit_period">Period</string> | ||||||
| <string name="feature_recurringDeposit_minimum_balance_for_interest">Minimum Balance For Interest Calculation</string> | ||||||
| <string name="feature_recurringDeposit_back">Back</string> | ||||||
| <string name="feature_recurringDeposit_next">Next</string> | ||||||
| <string name="feature_recurringDeposit_no_internet_connection">No Internet Connection</string> | ||||||
| </resources> | ||||||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /* | ||
| * Copyright 2025 Mifos Initiative | ||
| * | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| * | ||
| * See https://github.com/openMF/android-client/blob/master/LICENSE.md | ||
| */ | ||
| package com.mifos.feature.recurringDeposit.di | ||
|
|
||
| import com.mifos.feature.recurringDeposit.newRecurringDepositAccount.RecurringAccountViewModel | ||
| import org.koin.core.module.dsl.viewModelOf | ||
| import org.koin.dsl.module | ||
|
|
||
| val RecurringDepositModule = module { | ||
| viewModelOf(::RecurringAccountViewModel) | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -15,19 +15,26 @@ import androidx.navigation.compose.composable | |||||||||||||
| import kotlinx.serialization.Serializable | ||||||||||||||
|
|
||||||||||||||
| @Serializable | ||||||||||||||
| data object RecurringAccountRoute | ||||||||||||||
| data class RecurringAccountRoute( | ||||||||||||||
| val clientId: Int = -1, | ||||||||||||||
| ) | ||||||||||||||
|
Comment on lines
+18
to
+20
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Validate or remove the default clientId value. The default value of
-data class RecurringAccountRoute(
- val clientId: Int = -1,
-)
+data class RecurringAccountRoute(
+ val clientId: Int,
+)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||
|
|
||||||||||||||
| fun NavGraphBuilder.recurringAccountDestination() { | ||||||||||||||
| fun NavGraphBuilder.recurringAccountDestination( | ||||||||||||||
| navController: NavController, | ||||||||||||||
| ) { | ||||||||||||||
| composable<RecurringAccountRoute> { | ||||||||||||||
| RecurringAccountScreen( | ||||||||||||||
| navController = navController, | ||||||||||||||
| onNavigateBack = {}, | ||||||||||||||
| onFinish = {}, | ||||||||||||||
| ) | ||||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| fun NavController.navigateToRecurringAccountRoute() { | ||||||||||||||
| fun NavController.navigateToRecurringAccountRoute( | ||||||||||||||
| clientId: Int, | ||||||||||||||
| ) { | ||||||||||||||
| this.navigate( | ||||||||||||||
| RecurringAccountRoute, | ||||||||||||||
| RecurringAccountRoute(clientId = clientId), | ||||||||||||||
| ) | ||||||||||||||
| } | ||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you tell me why this has been commented out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a representation of that parameter in the api call.
It sends an empty array or object.
I also couldn't find its use.
So, in future, if someone does find its use or the proper representation of the data type, they can update the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to add a TODO comment for future reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sir. I will keep this in mind.