WIP: a particle only test case. #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

guj wants to merge 13 commits into openPMD:dev from guj:8c

Contributor

guj commented Sep 20, 2024

Particle only test for particles only.

example input file:

encoding=v
fileLocation=joined
maxMil=1
minMil=1
steps=2
joinedArray=true
backend=bp
usePDW=true

To do: simulate a BTD use case

guj and others added 11 commits

September 3, 2024 10:26


          added new test 8c for particles

640f64d

todo: BTD support


          added test 8c

fc47ffd


          added option to force PDW flush

d72a329


          warning fix

b0fa02d


          tabs

b29dd09

eol

4ce694f


          use defaults if no input file is supplied

309ad55


          minor fix with tabs

e6a2151


          added PDW string

bd1bb17


          parameter fix

b175dcc


          [pre-commit.ci] auto fixes from pre-commit.com hooks

348a1c3

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems

View reviewed changes

examples/8c_benchmark_ptl_parallel.cpp

+                  {
+                      m_Rank = rank;
+              #if defined(__linux)
+                      // m_Name = "/proc/meminfo";

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

examples/8c_benchmark_ptl_parallel.cpp

Comment on lines +151 to +155

+                      /*
+                      m_Silent = silent;
+                      if (!m_Silent)
+                             MemoryProfiler(rank, tag);
+                      */

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

examples/8c_benchmark_ptl_parallel.cpp

+                  std::string m_Tag;
+                  int m_Rank = 0;
+                  // bool m_Silent = false;

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

examples/8c_benchmark_ptl_parallel.cpp Fixed Show fixed Hide fixed

examples/8c_benchmark_ptl_parallel.cpp

+                      for (const auto &[name, p] : m_GlobalProfilers)
+                      {
+                          std::vector<double> result(input.m_MPISize, 0);
+                          // unsigned long  buffer[m_Input.m_MPISize];

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

examples/8c_benchmark_ptl_parallel.cpp Fixed Show fixed Hide fixed

examples/8c_benchmark_ptl_parallel.cpp

Comment on lines +743 to +744

		// currSpecies["positionOffset"]["x"].resetDataset(realDataSet);
		// currSpecies["positionOffset"]["x"].makeConstant(0.);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

examples/8c_benchmark_ptl_parallel.cpp

+                      if (m_Input.m_UseJoinedDim)
+                          return;
+                  }
+                  // Timer g("Gather Particle logistics ", m_Input.m_MPIRank);

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.

examples/8c_benchmark_ptl_parallel.cpp Fixed Show fixed Hide fixed

guj and others added 2 commits

September 20, 2024 14:11


          touch up after CodeQL

e1c36f4


          [pre-commit.ci] auto fixes from pre-commit.com hooks

ab0ba02

for more information, see https://pre-commit.ci

github-advanced-security bot found potential problems

View reviewed changes

examples/8c_benchmark_ptl_parallel.cpp

+                  {
+                      std::string filename = argv[1];
+                      std::fstream infile;
+                      infile.open(filename, std::ios::in);

Check failure

Code scanning / CodeQL

Uncontrolled data used in path expression High

This argument to a file access function is derived from

user input (a command-line argument)

and then passed to std::basic_fstream<char, char_traits>::open(__s).
This argument to a file access function is derived from

user input (a command-line argument)

and then passed to std::basic_fstream<char, char_traits>::open(__s), which calls std::basic_filebuf<char, char_traits>::open(__s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet