Make pybel compatible with #1975 #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Good fix, but I would suggest some changes. I don't think we should keep the legacy names. The whole problem is that valence and degree were mixed up. If we keep the legacy names, we perpetuate the confusion. Also, "def valence" should be renamed to "def degree", and the Atom docstring should be updated. |
old properties will raise the error
|
Thanks for suggestion. So there are the changes I have made:
|
|
@baoilleach - ready to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some change of
pybel.pyto compatible with function name changes in #1975. Some property names were changed keeping the original name as the alias.heavyvalence->heavydegreeheterovalence->heterodegree