Skip to content

Conversation

julie-sullivan
Copy link
Collaborator

Please see Todd's document for a full description of the bug, but here is a summary:

  1. example query input: 1:100:A:G with parameters: checkAminoAcidChange = true, ignorePhase=false
  2. HGVS value is used to query results not the variant coordinates e.g. p.Met1?
  3. Query results may include more than one variant matching p.Met1?: 4. e.g. 1:100:A:G (3 trait associations) 1:101:A:G (2 trait associations) 1:101:T:C (7 trait associations)
  4. code picks the first result and ignores the rest.

Also we have a unit test but it uses mockito. Do you want it anyway?

15:90766924:T:G,15:90766927:G:T were the original problematic variants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant