Skip to content

TASK-6981 - Should not use same Solr timeout for reading and for indexing #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: release-3.x.x
Choose a base branch
from
Open

TASK-6981 - Should not use same Solr timeout for reading and for indexing #2512

wants to merge 6 commits into from

Conversation

jtarraga
Copy link
Member

@jtarraga jtarraga requested a review from j-coll September 27, 2024 11:02
@halender
Copy link
Contributor

Task linked: TASK-6981 Should not use same Solr timeout for reading and for indexing

j-coll
j-coll requested changes Sep 30, 2024
View reviewed changes
opencga-core/src/main/java/org/opencb/opencga/core/config/SearchConfiguration.java
return this;
}

@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not remove these methods.
Leave the methods deprecated, and just call to the static method
Configuration.reportUnusedField()

e.g.

opencga/opencga-core/src/main/java/org/opencb/opencga/core/config/Configuration.java

Lines 304 to 313 in e7f1966

@Deprecated
public Admin getAdmin() {
return null;
}
@Deprecated
public Configuration setAdmin(Admin admin) {
reportUnusedField("configuration.yml#admin", admin);
return this;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will avoid failures in "old" configuration files that might be using the "rows" or "host" field.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ticket should have, in the "Communications" a message saying that this fields are removed.

@j-coll j-coll changed the title [TASK-6981] Should not use same Solr timeout for reading and for indexing TASK-6981- Should not use same Solr timeout for reading and for indexing Sep 30, 2024
@jtarraga
search: update according to java-common-libs changes, and recover the…
c8a00b0 
… deleled methods to mark them as deprecated for backward-compatibility, #TASK-6981
@jtarraga
Merge branch 'release-3.x.x' into TASK-6981
68c45d2
@jtarraga jtarraga requested a review from j-coll October 2, 2024 07:41
@j-coll j-coll changed the title TASK-6981- Should not use same Solr timeout for reading and for indexing TASK-6981 - Should not use same Solr timeout for reading and for indexing Oct 2, 2024
j-coll
j-coll previously approved these changes Oct 4, 2024
View reviewed changes
@jtarraga jtarraga requested a review from j-coll October 7, 2024 11:10
j-coll
j-coll previously approved these changes Oct 7, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j-coll j-coll j-coll left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtarraga @halender @j-coll