Train related tests #491
Merged
Train related tests #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 13, 2025
dfulu
reviewed
Oct 23, 2025
dfulu
reviewed
Oct 23, 2025
dfulu
reviewed
Oct 23, 2025
tests/training/test_train.py
Outdated
| def wandb_offline_env(monkeypatch, session_tmp_path): | ||
| """Put W&B offline, quiet; force CPU.""" | ||
| save_dir = str(session_tmp_path / "wandb") | ||
| monkeypatch.setenv("WANDB_SILENT", "true") |
There was a problem hiding this comment.
We should avoid using environmental variables if we can. It adds complexity to the tests. Are these two variables needed for the test or do they clean up the test outputs or something?
There was a problem hiding this comment.
@felix-e-h-p thanks for the updates, I'm guessing the env vars weren't needed?
You might want to dropmonkeypatch now that its no longer used in this fixture and maybe update the fixture name and doc to reflect what it does now
There was a problem hiding this comment.
Ahh yeah! Sorry - well spotted. Will push now, finalised you reckon?
dfulu
reviewed
Oct 24, 2025
dfulu
reviewed
Oct 24, 2025
dfulu
reviewed
Oct 24, 2025
dfulu
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relating to #432
Also updated relative to data sampler modifications