Added missing enable=True to acl_action_data_t in IPv6NextHdrTest (sa… #2202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iacl module) Signed-off-by: Kandankarunai Thiruppathi <[email protected]>
kandancs
force-pushed
the
IPv6NextHdrTest_Issue
branch
from
21d685f to
0ac9ddf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable=True was needed in acl_action_data_t of the IPv6NextHdrTest test case (saiacl module)
Problem statement:
IPv6NextHdrTest(saiacl module) needs modification as per SAI Standard.
in IPv6NextHdrTest(saiacl) while configuring acl_action_data_t enable flag is missing. But as per SAI Header/standard sai_action paramer valid only when enable flag set to TRUE.
SAI Testcase link: https://github.com/opencomputeproject/SAI/blob/master/ptf/saiacl.py#L4799C36-L4799C51
673 typedef struct _sai_acl_action_data_t
674 {
675 /**
676 * @brief Action enable/disable
677 /
678 bool enable;
679
680 /*
681 * @brief Action parameter
682 *
683 * @passparam meta
684 *** @validonly enable == true**
685 */
686 sai_acl_action_parameter_t parameter;
687
688 } sai_acl_action_data_t;
SAI Header link: https://github.com/opencomputeproject/SAI/blob/master/inc/saitypes.h#L691
Fix:
Included the enable=True flag in the sai_thrift_acl_action_parameter_t setup used in the IPv6NextHdrTest test case in saiacl.py