Skip to content

Create API for fast linkup configuration. #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create API for fast linkup configuration. #2203

wants to merge 1 commit into from
+110 −0

Conversation

iamjustadd
Copy link

Hi team,

This PR is for creating SAI API for FR fast linkup.

@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 0693a69 to a62e203 Compare September 9, 2025 04:20
@bingwang-ms
Copy link
Contributor

@prgeor Can you help review?

@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch 2 times, most recently from c5c2e4a to f69d599 Compare September 15, 2025 06:21
prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
inc/saiswitch.h Outdated
* @type sai_u16_range_t
* @flags READ_ONLY
*/
SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd What is the use case for this? How many samples will be used to derive the past link up time?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd What is the use case for this? How many samples will be used to derive the past link up time?

SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE is used to obtain the range that can be used for configuration of SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME. Please clarify regarding the "samples" question

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User should call SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE before set FAST_LINKUP_POLLING_TIME. Different vendor may got different range.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User should call SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE before set FAST_LINKUP_POLLING_TIME. Different vendor may got different range.

correct. It is the purpose of SAI_SWITCH_ATTR_FAST_LINKUP_POLLING_TIME_RANGE

prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
inc/saiswitch.h Outdated
/**
* @brief Time (in secs) during which the link must be UP and have the BER below the level configured with SAI_SWITCH_ATTR_FAST_LINKUP_GUARD_TIME_BER to have the next linkup as fast link-up
*
* If either link failures or high BER event happen during the configured time then full link-up flow (not fast) will be used for next link-up.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd Which is the "configured time" referring to here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamjustadd Which is the "configured time" referring to here?

SAI_SWITCH_ATTR_FAST_LINKUP_GUARD_TIME

prgeor
prgeor reviewed Sep 15, 2025
View reviewed changes
@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch 2 times, most recently from 46db2be to bc82fce Compare September 16, 2025 08:06
@iamjustadd iamjustadd requested a review from prgeor September 16, 2025 08:10
@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch from bc82fce to 8f84bcf Compare September 19, 2025 01:14
@eddyk-nvidia
Copy link

@prgeor , @JaiOCP - could you please approve the PR ? All comments at the community review were addressed. Thanks

prgeor
prgeor reviewed Sep 21, 2025
View reviewed changes
prgeor
prgeor reviewed Sep 21, 2025
View reviewed changes
@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 8f84bcf to 62b4c9b Compare September 22, 2025 06:34
@iamjustadd iamjustadd requested a review from prgeor September 22, 2025 06:35
@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch 2 times, most recently from f8f9e35 to 0694b31 Compare September 22, 2025 06:43
@prgeor
Copy link
Collaborator

prgeor commented Sep 22, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor
Copy link
Collaborator

prgeor commented Sep 22, 2025

@iamjustadd build failure. please fix

@tjchadaga tjchadaga added the reviewed PR is discussed in SAI Meeting label Sep 22, 2025
@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 0694b31 to 0851a8f Compare September 23, 2025 06:54
@iamjustadd
Copy link
Author

@eddyk-nvidia @prgeor

  1. Previous brief of SAI_SWITCH_ATTR_FAST_LINKUP_BER_THRESHOLD is too long to pass the sanity check, I shorten the brief of it.
  2. Previously, metadata generator is not compitable with sai_u16_range_t, I fix it also in this PR.

Please help review on this.

Thanks.

@iamjustadd iamjustadd requested a review from prgeor September 23, 2025 06:56
@prgeor
Copy link
Collaborator

prgeor commented Sep 24, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 0851a8f to 7eb56d2 Compare September 25, 2025 02:36
@iamjustadd
Copy link
Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 2203 in repo opencomputeproject/SAI

@iamjustadd iamjustadd closed this Sep 25, 2025
@iamjustadd iamjustadd force-pushed the dev_master_sai_fast_linkup branch from 7eb56d2 to 9658eeb Compare September 25, 2025 02:46
@iamjustadd iamjustadd reopened this Sep 25, 2025
@prgeor
Copy link
Collaborator

prgeor commented Sep 25, 2025

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

prgeor
prgeor reviewed Sep 25, 2025
View reviewed changes
Copy link
Collaborator

@prgeor prgeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaiOCP any comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prgeor prgeor prgeor approved these changes

+1 more reviewer

@eddyk-nvidia eddyk-nvidia eddyk-nvidia left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
reviewed PR is discussed in SAI Meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamjustadd @bingwang-ms @eddyk-nvidia @prgeor @tjchadaga