Skip to content

Conversation

@f4ni
Copy link

@f4ni f4ni commented Oct 17, 2025

This PR fixes a typo in the enum definition for dash_flow_entry_bulk_get_session_filter_key_t where the member INVAILD is corrected to INVALID.

Changes:

  • saitypesextensions.h: Renamed enum member INVAILD → INVALID.

Following will be pushed to DASH's repo once these SAI repo changes are merged.

  • dash_headers.p4: Renamed enum member INVAILD → INVALID.
  • The updated SAI spec

Rationale:
The incorrect spelling (INVAILD) exists both in DASH’s P4 headers and in the SAI specification. This mismatch causes header generation to fail when fixing the typo in P4 alone. By correcting the typo in both SAI and DASH, we maintain consistency and enable successful SAI header generation.

Impact:

  • Fixes enum naming inconsistency.
  • Allows SAI header generation to proceed without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant