Skip to content

fixes code injection because cypher allows new line with single quote #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes code injection because cypher allows new line with single quote #370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef8eb5
fixes code injection because cypher allows new line with single quote
ExtReMLapin Mar 3, 2025
74519a0
update copyright year in StringTranslationUtils.java (compiler keeps …
ExtReMLapin Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions ...ation/src/main/java/org/opencypher/gremlin/translation/groovy/StringTranslationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,22 @@ public static String toLiteral(Object argument) {
return argument.toString();
}

private static String toStringLiteral(String agrument) {
String s = agrument.replaceAll("(['\\\\])", "\\\\$1");
if (s.contains("\n")) {
return "\"\"\"" + s + "\"\"\"";
private static String toStringLiteral(String argument) {
if (argument.contains("\n")) {
// Handle multiline strings
if (argument.contains("\"\"\"")) {
// If the string contains """, use single quotes and escape newlines and quotes
return "'" + argument.replaceAll("(['\\\\])", "\\\\$1")
.replaceAll("\n", "\\\\n")
.replaceAll("\r", "\\\\r") + "'";
} else {
// Use triple quotes for multiline strings, but escape any ending triple quotes
String processed = argument.replaceAll("\"\"\"", "\\\\\"\\\\\"\\\\\"");
return "\"\"\"" + processed + "\"\"\"";
}
} else {
return "'" + s + "'";
// For single line strings, use the original approach with single quotes
return "'" + argument.replaceAll("(['\\\\])", "\\\\$1") + "'";
}
}

Expand Down