feature(zjow): envpoool env example in new pipeline #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 1, 2023
PaParaZz1
requested changes
Nov 15, 2023
| def __init__(self, cfg: EasyDict) -> None: | ||
| self._cfg = cfg | ||
| self._cfg = self.default_config() | ||
| self._cfg.update(cfg) |
There was a problem hiding this comment.
why merge config here, we have already merged the config of env manager in compile_config function
There was a problem hiding this comment.
There are two env manager config, one for evaluator and one for collector. It's too complicated to use compile_config with auto=True.
I suggest use compile_config with auto=False.
PaParaZz1
requested changes
Nov 23, 2023
| ) | ||
| ) | ||
| #task.use(CkptSaver(policy, cfg.exp_name, train_freq=1000)) | ||
| task.use(termination_checker(max_env_step=10000000)) |
| ) | ||
| task.use(data_pusher(cfg, buffer_)) | ||
| task.use(EnvpoolOffPolicyLearner(cfg, policy, buffer_)) | ||
| task.use(online_logger(train_show_freq=10)) |
|
|
||
| def main(cfg): | ||
| logging.getLogger().setLevel(logging.INFO) | ||
| cfg.exp_name = 'Pong-v5-DQN-envpool-' + datetime.datetime.now().strftime("%Y%m%d-%H%M%S") |
| 'episodic_life': True, # collector: True | ||
| 'reward_clip': False, # collector: True | ||
| 'gray_scale': cfg.env.get('gray_scale', True), | ||
| 'stack_num': cfg.env.get('stack_num', 4), |
There was a problem hiding this comment.
move some keys to default config and user config
|
This PR will be continually updated in #753. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.