Embeddable registration form #1045
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: Adding embedded registration form VAN-1574
Description: Applied frontend validations on all the fields VAN-1614
syedsajjadkazmii
force-pushed
the
embeddable-registration-form
branch
from
aeec576 to
7811f49
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1045 +/- ##
==========================================
+ Coverage 86.99% 87.13% +0.13%
==========================================
Files 124 125 +1
Lines 2269 2317 +48
Branches 626 628 +2
==========================================
+ Hits 1974 2019 +45
- Misses 286 289 +3
Partials 9 9
☔ View full report in Codecov by Sentry. |
syedsajjadkazmii
force-pushed
the
embeddable-registration-form
branch
from
7811f49 to
0e7e748
Compare
mubbsharanwar
approved these changes
Sep 8, 2023
Comment on lines
+39
to
+40
| registrationError, | ||
| registrationError: { |
There was a problem hiding this comment.
why are we using registrationError twice?
There was a problem hiding this comment.
@mubbsharanwar its nested destructuring, its mostly used when we both need the object and property from inside the object. So we destructure it like this.
|
The work is completed. We are converting it draft and will use it when we will do multi-step embedded form work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the Embedded Registration Page from the conventional registration page component into a new component.
JIRA
VAN-1611
How Has This Been Tested?
Locally