-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Mathjax for formules formatting #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Mathjax for formules formatting #339
Conversation
|
Thanks for the pull request, @vladislavkeblysh! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
cef5cd1 to
7fdea6a
Compare
78d62f7 to
a341093
Compare
|
Has problem with CI checker. Tried to use node version 18.19 and npm 9/10. Problems still unsolved |
9f68c68 to
3612fe9
Compare
|
@vladislavkeblysh I tried pulling this locally and running nvm use
npm ciand I was able to reproduce the error CI is showing. I then ran npm installand then npm ciand the error was no longer there. This makes me think that CI should make it past the current error if you run npm installand check in the updated |
|
@brian-smith-tcril I did the same thing, but the problem persists. |
|
@vladislavkeblysh what do you see locally when running rm -rf node_modules
nvm use
npm ci |
|
We'll probably want product review, here. Mathjax support across the platform is somewhat inconsistent, and we'll likely want to figure out a strategy going forward. |
|
@jmakowski1123 - is there a product roadmap ticket for this? |
dad60b5 to
21c5cf7
Compare
21c5cf7 to
6d0184e
Compare
|
This one needs a roadmap ticket and product review. |
Thanks @jmakowski1123 - can you link to the roadmap ticket here (once it's live)? |
6d0184e to
312359e
Compare
312359e to
1950fa2
Compare
3cf6bb7 to
98fdf51
Compare
2ec2d63 to
6bf2025
Compare
bface11 to
2a2b4e4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 1086 1086
Branches 161 160 -1
=========================================
Hits 1086 1086 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arbrandes @brian-smith-tcril ready to review |
|
Per @jmakowski1123 this does not need to go through Prod review. All set to merge after review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks alright, but I'm concerned that this uses a completely different method to load MathJax than the current pattern in the codebase, which is to load MathJax 2.7.5 directly from a CDN. (edx-platform example, frontend example).
I also don't see an attempt to replicate the MathJax configuration used elsewhere (edx-platform example, frontend example). What makes this worse is that apparently there is no single configuration pattern in the codebase. Has an evaluation been made to check that what configuration is actually necessary?
In other words: how likely is it that loading MathJax via better-react-mathjax will result in a rendering that is different than what the author intended?
|
@arbrandes Thanks for pointing that out. I’ve checked both MathJax configurations you referenced. I’ve updated the configuration in better-react-mathjax to match them: |
Remove reactifex and @edx/reactifex packages from devDependencies as they are no longer needed. Translation extraction functionality has been verified to work correctly without these dependencies. Co-Authored-By: Claude <[email protected]>
Co-authored-by: ihor-romaniuk <[email protected]>
7d63884 to
b481d8e
Compare
Description
Screenshots before:
Screenshots after: