Skip to content

Conversation

@vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Jun 12, 2024

Description

  • Add Mathjax lib for formatting formules

Screenshots before:

image

Screenshots after:

image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 12, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 12, 2024

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @codewithemad.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch 3 times, most recently from cef5cd1 to 7fdea6a Compare June 12, 2024 17:02
@vladislavkeblysh vladislavkeblysh self-assigned this Jun 12, 2024
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch 2 times, most recently from 78d62f7 to a341093 Compare June 13, 2024 10:17
@vladislavkeblysh
Copy link
Contributor Author

vladislavkeblysh commented Jun 13, 2024

Has problem with CI checker. Tried to use node version 18.19 and npm 9/10. Problems still unsolved

@brian-smith-tcril
Copy link
Contributor

@vladislavkeblysh I tried pulling this locally and running

nvm use
npm ci

and I was able to reproduce the error CI is showing. I then ran

npm install

and then

npm ci

and the error was no longer there.

This makes me think that CI should make it past the current error if you run

npm install

and check in the updated package-lock.json

@vladislavkeblysh
Copy link
Contributor Author

@brian-smith-tcril I did the same thing, but the problem persists.

@brian-smith-tcril
Copy link
Contributor

@vladislavkeblysh what do you see locally when running

rm -rf node_modules
nvm use
npm ci

@arbrandes
Copy link
Contributor

We'll probably want product review, here. Mathjax support across the platform is somewhat inconsistent, and we'll likely want to figure out a strategy going forward.

@mphilbrick211 mphilbrick211 added the product review PR requires product review before merging label Jul 30, 2024
@mphilbrick211
Copy link

@jmakowski1123 - is there a product roadmap ticket for this?

@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch from dad60b5 to 21c5cf7 Compare January 7, 2025 18:46
@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/ora-formules-format branch from 21c5cf7 to 6d0184e Compare February 3, 2025 08:36
@jmakowski1123
Copy link

This one needs a roadmap ticket and product review.

@mphilbrick211
Copy link

This one needs a roadmap ticket and product review.

Thanks @jmakowski1123 - can you link to the roadmap ticket here (once it's live)?

@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/ora-formules-format branch from 6d0184e to 312359e Compare August 13, 2025 10:28
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch from 312359e to 1950fa2 Compare September 22, 2025 07:40
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch 3 times, most recently from 3cf6bb7 to 98fdf51 Compare September 23, 2025 09:10
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch 2 times, most recently from 2ec2d63 to 6bf2025 Compare September 23, 2025 10:05
@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/ora-formules-format branch from bface11 to 2a2b4e4 Compare September 23, 2025 10:12
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (508c91d) to head (fb8a4db).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #339   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1086      1086           
  Branches       161       160    -1     
=========================================
  Hits          1086      1086           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vladislavkeblysh
Copy link
Contributor Author

@arbrandes @brian-smith-tcril ready to review

@mphilbrick211
Copy link

Per @jmakowski1123 this does not need to go through Prod review. All set to merge after review.

@mphilbrick211 mphilbrick211 removed the product review PR requires product review before merging label Sep 23, 2025
@mphilbrick211 mphilbrick211 moved this from Product Review to Ready for Review in Contributions Sep 23, 2025
Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks alright, but I'm concerned that this uses a completely different method to load MathJax than the current pattern in the codebase, which is to load MathJax 2.7.5 directly from a CDN. (edx-platform example, frontend example).

I also don't see an attempt to replicate the MathJax configuration used elsewhere (edx-platform example, frontend example). What makes this worse is that apparently there is no single configuration pattern in the codebase. Has an evaluation been made to check that what configuration is actually necessary?

In other words: how likely is it that loading MathJax via better-react-mathjax will result in a rendering that is different than what the author intended?

@vladislavkeblysh
Copy link
Contributor Author

@arbrandes Thanks for pointing that out. I’ve checked both MathJax configurations you referenced.

I’ve updated the configuration in better-react-mathjax to match them:
• MathJax v2.7.5 (same as current CDN load)
• inlineMath and displayMath definitions from both templates
• processEscapes: true and SVG max-width fixes
• messageStyle: 'none' and automatic linebreaks for all output types

vladislavkeblysh and others added 5 commits October 15, 2025 10:15
Remove reactifex and @edx/reactifex packages from devDependencies as they are no longer
needed. Translation extraction functionality has been verified to work
correctly without these dependencies.

Co-Authored-By: Claude <[email protected]>
@vladislavkeblysh vladislavkeblysh force-pushed the keblysh/feat/ora-formules-format branch from 7d63884 to b481d8e Compare October 15, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

8 participants