Skip to content

Conversation

Anas12091101
Copy link
Contributor

@Anas12091101 Anas12091101 commented Sep 17, 2025

This PR updates frontend-component-header to v8 in order to enable support for LearningUserMenuToggleSlot and DesktopUserMenuToggleSlot

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 17, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @Anas12091101!

This repository is currently maintained by @codewithemad.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211
Copy link

Hi @Anas12091101! Looks like there's a couple of failing checks here. Would you mind taking a look?

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (508c91d) to head (2655574).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #468   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          107       107           
  Lines         1086      1086           
  Branches       161       161           
=========================================
  Hits          1086      1086           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Anas12091101 Anas12091101 force-pushed the anas/bump-frontend-component-header branch from 0933554 to cd6e947 Compare October 8, 2025 06:49
@Anas12091101 Anas12091101 requested a review from arbrandes October 8, 2025 07:15
@asadali145 asadali145 moved this from Waiting on Author to Ready for Review in Contributions Oct 14, 2025
@Anas12091101 Anas12091101 force-pushed the anas/bump-frontend-component-header branch from cd6e947 to 2655574 Compare October 17, 2025 10:37
@Anas12091101 Anas12091101 changed the title chore: bump frontend-component-header to v6.6.x chore: bump frontend-component-header to v8 Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants