IsObject(null) returns null, not false #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Problem:__ The function isObject should return true or false, depending if the supplied parameter is a true object, but if we call it with null it will return null ``` isObject(null) //returns null ``` __Solution:__ If we wrap the value inside !! we avoid this edge case, ensuring false will be returned if the parameter is null ``` isObject(null); // returns false ````
|
Rightly pointed out. I was also going through the codebase and figured it out now. Thought of making a PR, but saw yours. Good job 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The function isObject should return true or false, depending if the supplied parameter is a true object, but if we call it with null it will return null
Solution:
If we wrap the value inside !! we avoid this edge case, ensuring false will be returned if the parameter is null